feat(@schematics/angular): set up fake timers in beforeEach instead of beforeAll - #33130
Conversation
…f beforeAll When migrating `fakeAsync` to vitest fake timers, fake timers were setup in `beforeAll` to support `fakeAsync` usage in `beforeAll` / `afterAll` hooks. This was sacrificing timers isolation between tests. This change resets fake timers between tests. Any usage of fake timers APIs in `beforeAll` or `afterAll` hooks will fail.
There was a problem hiding this comment.
Code Review
This pull request updates the Jasmine-to-Vitest transformer to use "beforeEach" and "afterEach" hooks instead of "beforeAll" and "afterAll" when setting up and tearing down fake timers. This change ensures that fake timers are correctly initialized and reset for every individual test within a suite. I have no feedback to provide as there were no review comments to evaluate.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When migrating
fakeAsyncto Vitest fake timers, fake timers were setup inbeforeAllto supportfakeAsyncusage inbeforeAll/afterAllhooks.As brought up by @atscott, this was sacrificing timers isolation between tests.
This change resets fake timers between tests.
Any usage of fake timers APIs in
beforeAllorafterAllhooks will fail.PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information