Skip to content

build: temporarily disable @typescript-eslint/no-unnecessary-type-assertion - #33122

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:build/eslint-temp-disable
May 4, 2026
Merged

build: temporarily disable @typescript-eslint/no-unnecessary-type-assertion#33122
clydin merged 1 commit into
angular:mainfrom
clydin:build/eslint-temp-disable

Conversation

@clydin

@clydin clydin commented May 4, 2026

Copy link
Copy Markdown
Member

Disables the unnecessary type assertion lint rule across the repository to accommodate an upcoming typescript-eslint upgrade. The updated version introduces rule modifications that generate a significant volume of validation failures, which would block the upgrade process. Temporarily disabling the rule provides a path forward for the version bump, after which the codebase can be audited and the rule can be re-enabled incrementally.

@clydin clydin added the target: minor This PR is targeted for the next minor release label May 4, 2026
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label May 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ESLint configuration to disable the @typescript-eslint/no-unnecessary-type-assertion rule. Feedback was provided to include a trailing comma for consistency and a TODO comment to track the eventual re-enabling of the rule.

Comment thread eslint.config.mjs Outdated
…ertion

Disables the unnecessary type assertion lint rule across the repository to accommodate an upcoming typescript-eslint upgrade. The updated version introduces rule modifications that generate a significant volume of validation failures, which would block the upgrade process. Temporarily disabling the rule provides a path forward for the version bump, after which the codebase can be audited and the rule can be re-enabled incrementally.
@clydin
clydin force-pushed the build/eslint-temp-disable branch from 0bcfb5d to 634b792 Compare May 4, 2026 16:32
@clydin
clydin requested a review from alan-agius4 May 4, 2026 16:33
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 4, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 4, 2026
@clydin
clydin merged commit 086e081 into angular:main May 4, 2026
36 checks passed
@clydin

clydin commented May 4, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the build/eslint-temp-disable branch May 4, 2026 21:21
@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants