fix(@schematics/angular): use service decorator in ng generate

[crisbeto]

Updates the service schematic in ng generate to use the @Service decorator instead of @Injectable. There's also a new --injectable flag to get back the old behavior.

[alan-agius4]

Were there any discussions regarding the creation of a new schematic versus simply adding an option to the existing service schematic to support both @Injectable and @Service?

[crisbeto]

I mentioned in the design doc for @Service that I'm planning to change ng generate. I added the injectable schematic for symmetry, but I don't feel strongly about it.

[gemini-code-assist]

Code Review

This pull request introduces a new injectable schematic for generating Angular injectable classes and updates the existing service schematic to use a @Service decorator. The review feedback highlights several areas for improvement, including correcting a regex in the test suite that would cause failures, renaming variables and types to maintain consistency with the new schematic's purpose, removing an unused parameter, and updating documentation in the schema to accurately reflect default file naming.

[alan-agius4]

The new schematic also needs to be added in

angular-cli/packages/angular/cli/lib/config/workspace-schema.json

Line 174 in 0841637

"@schematics/angular:service": {

[crisbeto]

Updated the config file.

[alan-agius4]

@crisbeto, I synced with @clydin on this. We’d prefer to update the existing service schematic with an --injectable flag rather than introducing a separate schematic. We're looking to consolidate our schematics where possible.

[crisbeto]

I've updated it to remove the injectable schematic and add a --injectable flag instead.

[alan-agius4]

LGTM

[clydin]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 7fb59ea

[angular-automatic-lock-bot]

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}