refactor(@schematics/angular): remove third-party typescript copy - #33072
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the vendored TypeScript dependency from the third_party/typescript directory and replaces it with a direct dependency on the typescript package (version 6.0.3). The changes include updating Bazel build configurations, package.json, and numerous import statements across the schematics package. Feedback was provided regarding the inconsistent import style of the typescript package, suggesting the use of namespace imports (import * as ts) throughout the codebase for better consistency and compatibility.
82fd1f1 to
f65587e
Compare
The typescript package is now smaller and the tsserver file no longer bundles typescript but imports it directly, which makes the 3rd party copy redundant.
f65587e to
ae68b12
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The typescript package is now smaller and the tsserver file no longer bundles typescript but imports it directly, which makes the 3rd party copy redundant.