test(@angular/build): robustly install @angular/animations in e2e test - #33037
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the chunk-optimizer-animations E2E test to support Angular snapshot builds by dynamically determining the @angular/animations version based on the environment. A review comment suggests moving the snapshot manifest requirement inside the conditional block to prevent potential runtime errors in environments where the snapshot directory is absent.
Enhance the animations package installation in the E2E test to support snapshot E2E runs by resolving the exact dependency specifier from the ng-snapshot manifest when --ng-snapshots is active. Otherwise, it reads the full installed version of @angular/core directly from the local node_modules to avoid semver issues during package installation.
467a824 to
9239b1f
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Enhance the animations package installation in the E2E test to support snapshot E2E runs by resolving the exact dependency specifier from the ng-snapshot manifest when --ng-snapshots is active. Otherwise, it reads the full installed version of @angular/core directly from the local node_modules to avoid semver issues during package installation.