Skip to content

test(@angular/build): robustly install @angular/animations in e2e test - #33037

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
clydin:test/fix-chunk-opt-snapshots
Apr 24, 2026
Merged

test(@angular/build): robustly install @angular/animations in e2e test#33037
alan-agius4 merged 1 commit into
angular:mainfrom
clydin:test/fix-chunk-opt-snapshots

Conversation

@clydin

@clydin clydin commented Apr 23, 2026

Copy link
Copy Markdown
Member

Enhance the animations package installation in the E2E test to support snapshot E2E runs by resolving the exact dependency specifier from the ng-snapshot manifest when --ng-snapshots is active. Otherwise, it reads the full installed version of @angular/core directly from the local node_modules to avoid semver issues during package installation.

@clydin
clydin marked this pull request as ready for review April 23, 2026 15:04
@clydin
clydin requested review from alan-agius4 April 23, 2026 15:04
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Apr 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the chunk-optimizer-animations E2E test to support Angular snapshot builds by dynamically determining the @angular/animations version based on the environment. A review comment suggests moving the snapshot manifest requirement inside the conditional block to prevent potential runtime errors in environments where the snapshot directory is absent.

Comment thread tests/e2e/tests/build/chunk-optimizer-animations.ts Outdated
Comment thread tests/e2e/tests/build/chunk-optimizer-animations.ts Outdated
Enhance the animations package installation in the E2E test to support snapshot E2E runs by resolving the exact dependency specifier from the ng-snapshot manifest when --ng-snapshots is active. Otherwise, it reads the full installed version of @angular/core directly from the local node_modules to avoid semver issues during package installation.
@clydin
clydin force-pushed the test/fix-chunk-opt-snapshots branch from 467a824 to 9239b1f Compare April 23, 2026 15:53
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 23, 2026
@alan-agius4
alan-agius4 merged commit 7a0638f into angular:main Apr 24, 2026
36 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the test/fix-chunk-opt-snapshots branch April 24, 2026 11:11
@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants