refactor(@schematics/angular): remove explicit strict true in tsconfig template for TS6 compatibility - #32993
Conversation
…g template for TS6 compatibility TypeScript 6 enables strict mode by default. This change updates the workspace schematic's `tsconfig.json` template to omit `"strict": true` when strict mode is desired (relying on the default), and explicitly sets `"strict": false` when it is disabled.
There was a problem hiding this comment.
Code Review
This pull request modifies the tsconfig.json template to remove the explicit "strict": true setting when strict mode is enabled, while adding an explicit "strict": false when it is disabled. Feedback suggests that removing the explicit strict setting relies on TypeScript 6.0 defaults and will silently disable strict mode for users on older versions. It is recommended to keep the "strict": true setting explicit to ensure consistent type safety across all supported TypeScript versions and to update the corresponding tests to reflect this requirement.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
TypeScript 6 enables strict mode by default. This change updates the workspace schematic's
tsconfig.jsontemplate to omit"strict": truewhen strict mode is desired (relying on the default), and explicitly sets"strict": falsewhen it is disabled.