refactor(@schematics/angular): migrate typescript third-party dependency to node_modules - #32992
Conversation
0844943 to
a9994b7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the TypeScript dependency within the Angular schematics package, replacing a manually updated third-party directory with a Bazel genrule that pulls the required files directly from node_modules. However, the current implementation will cause a Bazel build error because a physical index.d.ts file exists in the same package where the genrule is configured to produce an output with the same name. Both review comments correctly identify this conflict and recommend removing the physical file.
alan-agius4
added
the
action: review
…ncy to node_modules Relocates the typescript third-party dependency from `third_party/github.com/Microsoft/TypeScript` to `third_party/typescript`. This update changes the implementation to source the required TypeScript files directly from `node_modules` via a Bazel `genrule` instead of keeping them checked into the repository.
a9994b7 to
63354b1
Compare
alan-agius4
added
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Relocates the typescript third-party dependency from
third_party/github.com/Microsoft/TypeScripttothird_party/typescript.This update changes the implementation to source the required TypeScript files directly from
node_modulesvia a Bazelgenruleinstead of keeping them checked into the repository.