Skip to content

refactor(@schematics/angular): remove empty constructor from directive template - #32960

Merged
dgp1130 merged 1 commit into
angular:mainfrom
cexbrayat:fix/directive-template-remove-empty-constructor
Apr 8, 2026
Merged

refactor(@schematics/angular): remove empty constructor from directive template#32960
dgp1130 merged 1 commit into
angular:mainfrom
cexbrayat:fix/directive-template-remove-empty-constructor

Conversation

@cexbrayat

Copy link
Copy Markdown
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The directive template generates an empty constructor, which not really useful in modern Angular where inject is preferred.

What is the new behavior?

Align directive template with the component template cleanup done in 301b566.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…e template

Align directive template with the component template cleanup done in 301b566.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an empty constructor from the Angular directive template to streamline the generated code. As there are no review comments provided, I have no further feedback to offer.

@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Apr 8, 2026
@dgp1130
dgp1130 merged commit 06dc095 into angular:main Apr 8, 2026
38 checks passed
@dgp1130

dgp1130 commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants