refactor(@angular/cli): add type safety fallbacks and deduplicate search roots for MCP projects tool#32882
refactor(@angular/cli): add type safety fallbacks and deduplicate search roots for MCP projects tool#32882clydin wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces validation for project configuration elements (projectType, prefix, and builder) within the Angular MCP tool. It adds a validationErrors field to the output schema to report malformed or invalid schema elements. Additionally, a new utility function deduplicateSearchRoots was implemented to prevent redundant processing of overlapping search paths. Feedback was provided to refine the projectType validation check to ensure all non-undefined values are correctly validated, maintaining consistency with other property checks.
76c30b8 to
e00d403
Compare
…rch roots for MCP projects tool Added runtime type checks for `projectType` and `prefix` to prevent unhandled schema exceptions. Implemented `deduplicateSearchRoots` to filter out child directories from overlapping search trees, optimizing filesystem scans. Aggregated validation errors and reported them in the tool output for better visibility.
e00d403 to
ebbb01d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
1 participant
Added runtime type checks for
projectTypeandprefixto prevent unhandled schema exceptions. ImplementeddeduplicateSearchRootsto filter out child directories from overlapping search trees, optimizing filesystem scans. Aggregated validation errors and reported them in the tool output for better visibility.