Skip to content

fix(@angular/cli): fix sourceRoot resolution for MCP projects tool#32879

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
clydin:fix/mcp-projects-source-root
Mar 30, 2026
Merged

fix(@angular/cli): fix sourceRoot resolution for MCP projects tool#32879
alan-agius4 merged 1 commit into
angular:mainfrom
clydin:fix/mcp-projects-source-root

Conversation

@clydin

@clydin clydin commented Mar 27, 2026

Copy link
Copy Markdown
Member

Ensure that project.sourceRoot is used directly as it is already relative to the workspace root, preventing duplicated path prefixes for sub-projects.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Mar 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the path resolution logic for project source roots to prevent incorrect path prefixing when sourceRoot is already defined. I have no feedback to provide.

@clydin
clydin force-pushed the fix/mcp-projects-source-root branch from da4418e to 8be48af Compare March 27, 2026 17:00
Ensure that project.sourceRoot is used directly as it is already relative to the workspace root, preventing duplicated path prefixes for sub-projects.
@clydin
clydin force-pushed the fix/mcp-projects-source-root branch from 8be48af to 9ba6527 Compare March 27, 2026 17:25
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 27, 2026
@clydin
clydin requested a review from alan-agius4 March 27, 2026 17:42
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 30, 2026
@alan-agius4
alan-agius4 merged commit 4815a54 into angular:main Mar 30, 2026
36 of 37 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the fix/mcp-projects-source-root branch March 30, 2026 10:40
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcp command list_projects incorrectly constructs sourceRoot for multi-project workspaces

2 participants