Skip to content

test: ignore HMR disabled console errors#32820

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:hmr-error-fix
Mar 23, 2026
Merged

test: ignore HMR disabled console errors#32820
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:hmr-error-fix

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

The e2e test utility now ignores browser console errors containing the string "Hot Module Replacement is disabled". This prevents tests from failing when running with HMR disabled.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly ignores the 'Hot Module Replacement is disabled' console error in e2e tests, preventing test failures when HMR is not active. The implementation is straightforward. I've added one suggestion to extract the hardcoded error message into a constant to improve code maintainability.

Comment thread tests/e2e/utils/puppeteer.ts Outdated
The e2e test utility now ignores browser console errors containing the string "Hot Module Replacement is disabled". This prevents tests from failing when running with HMR disabled.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 23, 2026
@alan-agius4
alan-agius4 requested a review from clydin March 23, 2026 15:47
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 23, 2026
@alan-agius4
alan-agius4 merged commit 240870e into angular:main Mar 23, 2026
37 checks passed
@alan-agius4
alan-agius4 deleted the hmr-error-fix branch March 23, 2026 16:08
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants