fix(@angular/build): remove default for unit-test coverage option#32805
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where the default false value for the coverage option in the unit-test builder schema would override coverage settings from a runner's configuration file (e.g., vitest.config.ts). By removing the default, the option can be undefined, allowing the runner's configuration to be respected. The description for the coverage option has also been helpfully updated to clarify this new behavior. The change is well-justified and properly implemented.
Removing the default value of `false` for the `coverage` schema option in the
unit-test builder. When a default was present, it forced the coverage check in
the Vitest plugins to override any user-provided `coverage: { enabled: true }`
values set within a custom `vitest.config.ts`.
Removing the default explicitly allows the option to be `undefined`, respecting
the fallback behavior of the runner configuration.
The description was also updated to explicitly document how the Vitest runner
resolves the coverage configuration when the builder flag is omitted.
7165324 to
4ab650f
Compare
clydin
added
the
action: review
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Removing the default value of
falsefor thecoverageschema option in the unit-test builder. When a default was present, it forced the coverage check in the Vitest plugins to override any user-providedcoverage: { enabled: true }values set within a customvitest.config.ts.Removing the default explicitly allows the option to be
undefined, respecting the fallback behavior of the runner configuration.The description was also updated to explicitly document how the Vitest runner resolves the coverage configuration when the builder flag is omitted.