This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Open
Conversation
Contributor
|
I'm hesitant to accept this change because a quick Google search on the key code 229 does not necessarily indicate a backspace key press. It actually seems to just represent the browser being told the input buffer is busy and not finished accepting input which is most likely the case on the android keyboard especially if it has autocomplete or word suggestion enabled. |
Author
|
@lukepfeiffer10 ok, I'll try to make demo tomorrow |
|
Just made the same changes to mask.js, and wanted to make pull request because my nexus 3 generate code 229 when backspace. But here it is :) |
|
I can confirm this PR solves the issue #123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://stackoverflow.com/questions/25043934/is-it-ok-to-ignore-keydown-events-with-keycode-229/25509350
Input has placeholder and mask +0 999 999 99 99. On android device (nexus 7 android 6) if press backspace then catch event with key code 229, not 8.