You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed the issue with the autodiscovery, the service_matches is having a length of 0, however if we set the param host from the discovered addr and the port at 1 it is fixing the problem
I've just added a couple more validation checks, to make sure that an address is obtained either from a parameter or
it's obtained by searching for it.
Unfortunately during my current testing, I can't seem to trigger the line:
print("No services found for address ", addr, file=sys.stderr)
I'll try again, to see if I can get it to trigger, to see if your pull request fixes it for me.
You will not see the line No services found for address appearing as I removed this part of the code and replaced by a static information.
Instead of having the error message and quit the code, I updated the code in order to use the same behavior as using the --addr <ADDRESS> with a specific ADDRESS defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue with the autodiscovery, the service_matches is having a length of 0, however if we set the param host from the discovered addr and the port at 1 it is fixing the problem