fix: Order sqs messages#1181
Open
idhir-Cacib-armoniK wants to merge 7 commits intoaneoconsulting:mainfrom
Open
fix: Order sqs messages#1181idhir-Cacib-armoniK wants to merge 7 commits intoaneoconsulting:mainfrom
idhir-Cacib-armoniK wants to merge 7 commits intoaneoconsulting:mainfrom
Conversation
aneojgurhem
reviewed
Mar 18, 2026
idhir-Cacib-armoniK
force-pushed
the
im_cacib/fixOrderMessages
branch
from
73b0619 to
f78c36d
Compare
aneojgurhem
reviewed
Mar 19, 2026
Comment on lines
-71
to
73
| for (var i = 0; i < int.Max(options_.MaxPriority, | ||
| 1); i++) | ||
| var maxPriority = int.Max(options_.MaxPriority, | ||
| 1); | ||
| for (var i = maxPriority; i >= 1; i--) | ||
| { |
Contributor
There was a problem hiding this comment.
loop boundaries are not the same.
Contributor
Author
There was a problem hiding this comment.
yes and there was fat finger regarding the code below if you see. i +1 so we will begin from 11 to 2. I'll change the code below to have priority directly if ok for you :)
Contributor
Author
|
make it work first no need to run pipeline for nothing. |
aneojgurhem
reviewed
Mar 20, 2026
Contributor
There was a problem hiding this comment.
can you rebase/squash so that this file is not touched in the history
aneojgurhem
reviewed
Mar 20, 2026
Contributor
There was a problem hiding this comment.
can you rebase/squash so that this file is not touched in the history
- Arrange the code to avoid unecessary OrderbyDesc. - Add the unit test proving that we need to review the code. - Performing the code to have an order descending by Priority when pushing messages.
- Arrange the code to avoid unecessary OrderbyDesc. - Performing the code to have an order descending by Priority when pushing messages. - Remove fat finguer.
- Arrange the code to avoid unecessary OrderbyDesc. - Performing the code to have an order descending by Priority when pushing messages. - Remove fat finguer.
- Arrange the code to avoid unecessary OrderbyDesc. - Performing the code to have an order descending by Priority when pushing messages. - Remove fat finguer.
- Arrange the code to avoid unecessary OrderbyDesc. - Performing the code to have an order descending by Priority when pushing messages.
- Arrange the code to avoid unecessary OrderbyDesc. - Performing the code to have an order descending by Priority when pushing messages. - Style for .csproj and tests after removal
idhir-Cacib-armoniK
force-pushed
the
im_cacib/fixOrderMessages
branch
from
aa59b6a to
4817cae
Compare
- Arrange the code to avoid unecessary OrderbyDesc. - Performing the code to have an order descending by Priority when pushing messages. - Style for .csproj and tests after removal. - Put test as before as no need tests for this one :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The SQS messages pushed are ordered by the group and priority however it can not ensure that the highest priority will got first.
Description
Testing
A unit test was added to generate randome messages through priorities and ensure that first priority messages will be sent first.
Impact
Impact the messages with the highest priority will be taken first.
On SQS Consumers, the queue enlisted will be done from highest priority to the lowest.
Additional Information
Checklist