Open
Conversation
…e gridIteratorC_ or not.
Contributor
Author
|
@andysim OK, I'm not as experienced in the code coverage area - seems like it's failing because I added an extra check to make sure the signed vars aren't negative before casting to unsigned. Do I need to now add new tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several warnings that would be generated by GNU compilers with
-Wall, mostly signed/unsigned comparisons, adding preprocessor guards for OpenMP#pragmas, and initializing uninitialized variables.@andysim There is one change I would like you to review. In
helpme.hline 1603 there was an unused variable that I commented out:There is a class variable
gridIteratorC_that is being used instead below this. ShouldgridIteratorC_be getting assigned fromthreadedGridIteratorC_? Commenting it out doesn't seem to break anything but it looks like it might actually have a purpose so I wanted to check with you.