Open
Conversation
andysim
approved these changes
Nov 14, 2018
Owner
andysim
left a comment
andysim
left a comment
There was a problem hiding this comment.
Some really great cleanup in here: thank you so much for all the hard work. This looks like a far more elegant build ecosystem than the previous version. This is a very good demonstration of the power of interfaces in CMake, and I'm learning a lot by looking at the changes. I'm going to pull it to my laptop and our cluster to test before merging, but this looks really great :)
Tell Travis to get a recent CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build and install probably ok (though I wouldn't be surprised if omp not propagating. detection and use untested except for pymod in psi4.