feat: point unknown-flag errors at the command's help#78
Merged
Conversation
andyrewlee
force-pushed
the
audit/30-agentmd-exitcode-guard
branch
2 times, most recently
from
7093ce9 to
1ed526f
Compare
The unknown-command path is helpful (a did-you-mean suggestion plus 'run st help'), but an unknown flag dead-ended on the raw stdlib 'flag provided but not defined: -nope' with no pointer -- and fat-fingering a flag is more common than mistyping a command, for humans and agents guessing flag names. Wrap non-help parse errors at the single choke point (parseFlagSet) with '(run "st help <cmd>" for usage)' when the set is named. %w preserves the sentinel chain, the error code (error/exit 1), and the 'provided but not defined' text tests match.
andyrewlee
force-pushed
the
audit/31-unknown-flag-pointer
branch
from
8fb3693 to
20e2539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unknown-command path is helpful (a did-you-mean suggestion plus 'run st
help'), but an unknown flag dead-ended on the raw stdlib 'flag provided but not
defined: -nope' with no pointer -- and fat-fingering a flag is more common than
mistyping a command, for humans and agents guessing flag names. Wrap non-help
parse errors at the single choke point (parseFlagSet) with '(run "st help
" for usage)' when the set is named. %w preserves the sentinel chain, the
error code (error/exit 1), and the 'provided but not defined' text tests match.
Part of a 38-PR stacked diff (
audit/01…audit/38), reviewed and merged bottom-up. This PR is based onaudit/30-agentmd-exitcode-guard.