fix: measure shrink children via dry layout (#85)#98
Merged
Conversation
Replaces intrinsic-based shrink measurement with a dry layout pass using tight cross-axis and loose-bounded main-axis constraints. Intrinsic dimensions are 0 for SingleChildScrollView on its scroll axis, which caused shrink children to collapse when wrapping a scroll view. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Demonstrates ResizableSize.shrink() wrapping a SingleChildScrollView with variable-height content — the case from issue #85. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getMinIntrinsicHeight/Width(infinity)withchild.getDryLayout(...)forResizableSize.shrink()measurementExpandedwidgets work andSingleChildScrollViewreports its actual content size_getChildConstraintsdoes not re-measureFixes #85.
Background
SingleChildScrollViewreports0for intrinsic main-axis dimension on its scroll axis. The previous code calledgetMinIntrinsicHeight(double.infinity)for shrink sizing, so any shrink child wrapping a scroll view collapsed to zero. Intrinsics also passeddouble.infinityon the cross-axis, which is incorrect — the cross-axis is tight from the parent.Test plan
flutter test— 80/80 pass (79 existing + 1 new)ResizableSize.shrink()wrappingSingleChildScrollView(child: SizedBox(height: 150))reports150Known limitation
Nested
ResizableContaineras a shrink child still returns 0, sinceResizableLayoutRenderObjectdoes not overridecomputeDryLayout. Worth a follow-up.🤖 Generated with Claude Code