Open
Conversation
Owner
andrewmilson
left a comment
andrewmilson
left a comment
There was a problem hiding this comment.
TY. Can scripts/ and proof.* be removed please? I'd prefer to only have things that go hand in hand with the library.
| } | ||
|
|
||
| pub struct RegisterStates(Vec<RegisterState>); | ||
| pub struct RegisterStates(pub Vec<RegisterState>); |
Owner
There was a problem hiding this comment.
The types already implement deref. Is there a need to make this public?
Author
There was a problem hiding this comment.
Again I should've said WIP. Short-term fix to get this working:
https://github.com/ponderingdemocritus/darude/blob/main/wasm/src/lib.rs#L172-L183
Author
There was a problem hiding this comment.
IDK how to use deref to solve it, so just publicised it for now (we don't have to merge it in).
Comment on lines
-23
to
-26
| #[cfg(not(target_env = "msvc"))] | ||
| #[global_allocator] | ||
| static GLOBAL: Jemalloc = Jemalloc; | ||
|
|
Author
|
@andrewmilson sorry forgot to mark as WIP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.