Repository navigation
Fix add_fillet, drawing view scale and API lookups for SolidWorks 2024 users; release 2.1.0 (#255, #256, #257) - #259
Merged
Merged
Conversation
…s; scale spec says a missing scale keeps the sheet's
…se and replies tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three reports from a SolidWorks 2024 SP5 user (uvx + Claude Desktop). All three were our bugs. This PR also bumps the version to 2.1.0 so the fixes can ship.
Fixes
add_fillet(refs add_fillet fails with COM error "Invalid number of parameters" (DISP_E_BADPARAMCOUNT) on SolidWorks 2025 #255): below 2025 it switched toIFeatureManager.FeatureFillet3with 15 arguments, radius first. That method takes 14, options first, so the call could never work. Every version now makes theIModelDoc2.FeatureFillet3call proven on 2026.create_drawing_viewscale (refs create_drawing_view ignores the scale parameter (scale_applied: false) #256): the view never stopped using the sheet's scale, andscale_appliedwas always false. A givenscalenow becomes the view's own and is read back (scale_read). With noscale, the view keeps the sheet's, soset_sheet_scalestill applies.view_typesets the orientation whenorientationisn't given.~/.solidworks_mcp/docs-index. Old indexes are still read.Release 2.1.0
pyproject.toml,version.py,server.jsonanduv.locksay 2.1.0, and the CHANGELOG's unreleased entries are now under[2.1.0] - 2026-11-21. That's every change merged since 2.0.0, not only these fixes, hence a minor release rather than a patch. After the merge, pushing thev2.1.0tag publishes it.Checks
tests/live/test_live_sw_solidworks_2024_reports.pypassed 3 of 3 (fillet volume matches; views at 0.5 and 0.75 read back, isometric fromview_type; a lookup from a read-only folder saves its index in the user folder).