Repository navigation
Sketch essentials: fillets, chamfers, slots, trim, extend and construction geometry - #253
Merged
Merged
Conversation
…ing a structure review
…d, construction geometry; arc kinds and centre rectangle; construction honoured on SolidWorks (queue item 32)
…says the point isn't a corner (found live: a centre rectangle's centre point)
… says which worked (SolidWorks refused the first live)
…m returns False after trimming); fillets and chamfers last in guidance and the demo (the user's rule)
… live demo passed
…F (slowed to speed 2.5)
…slowed so every caption shows at least 3.5 s; the demo asks for 5 s per result caption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sketch essentials (queue item 32)
The sketch operations almost every real part needs after lines and circles: a rounded or bevelled corner, a slot, trimming a profile back to where shapes meet, extending a line to the next one, and construction geometry. Before this, an agent faked a slot from six entities and a rounded corner from lines and a hand-placed arc. Six new tools, 151 in all, all stable after the live demo below.
add_sketch_fillet[x, y](a rectangle's corners have no ids of their own)add_sketch_chamferadd_slotsketch_trimsketch_extendset_construction_geometryAlso:
add_arctakeskind:center(as before, the default),three_point(start, end and a point it passes through) ortangent(leaves the end of an existing entity tangent to it).add_rectangletakesfrom_center: the first point is the centre, the second a corner.Fixes
constructionnow works on SolidWorks.add_line,add_circleandadd_rectangleacceptedconstructionbut drew normal geometry, while the reply said"construction": true. The tools now set it on the new entity.Found in the live runs
invalid_input("it isn't where two entities meet") and changes nothing.SketchTrimreturnsFalseeven after it trims. Trim and extend are judged by measuring the sketch's total length before and after (a trim shortens it, an extension lengthens it), and the reply gives the change in mm.The demo: a slotted bracket plate
Every new operation in one part, built sharp with its corners filleted and chamfered last;
verify_modelchecks the volume against the hand calculation after each step:It's on the demos page (Sketching).
Also in this PR
Checks
Unit tests: 4,492 pass at 100% coverage; ruff and mypy are clean; the docs build in strict mode; every link checks out.
Live, passed 2026-11-19: