Repository navigation
generate_drawing_package fits every title-block field - #251
Merged
Merged
Conversation
Not just DWG NO. and TITLE: every field the sheet format fills from a property (material, drawn by, company...) is shrunk until it fits its box, and each is listed in the reply's title_block (#158).
ISO 7200 treats a subtitle as the supplementary title, under the title, and the company field as the legal owner's name only. The TITLE is set at 60% of the format's height so both lines fit (#158).
…very-field # Conflicts: # openspec/queue.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #250. Both edit the CHANGELOG's Unreleased section and the queue, so this one may need a one-line conflict fix there.
Every title-block field fits its box (part of #158)
generate_drawing_packageshrank only DWG NO. and TITLE until they fit; a long material name, company or DRAWN BY value ran over the next cell. Now every field the sheet format fills from a property ($PRP:"..."or$PRPSHEET:"...") is fitted the same way:title_block_text_height_mmwhen given.The reply's
title_blocklists each field:drawing numberandtitle.update_title_block's names:drawn by,drawn date,revisionandcompany.SW-Material.A property shown twice is fitted once, and labels (notes with no property) are left alone.
The subtitle is the TITLE's second line (#158)
subtitleused to fill the company field whencompanywas empty. ISO 7200 treats a subtitle as the supplementary title, which goes under the title, and the company field as the legal owner's name only. So now:companyonly.Still open on #158: measuring against the format's cell lines instead of the next note.
Checks
Unit tests:
titledoesn't overwrite TITLE's entry;4,330 tests pass at 100% coverage; ruff and mypy are clean; the docs build in strict mode.
Live: the fitting passed on 2026-11-17 (20 fields, all fit). The test now also passes
subtitleand checks that the TITLE readsPackage BlockthenBase support; that part is not run yet: