Typescript!!!#16
Open
danieldelcore wants to merge 3 commits into
Open
Conversation
danieldelcore
force-pushed
the
typescript
branch
from
28ca5fd to
23d18c9
Compare
danieldelcore
force-pushed
the
typescript
branch
from
61d259b to
b40ee24
Compare
danieldelcore
commented
Jun 23, 2020
| "start": "tsc --watch", | ||
| "prebuild": "npm run copy-static-files", | ||
| "build": "tsc --build", | ||
| "copy-static-files": "copyfiles -u 2 source/_static/**/* source/_static/**/**/* source/_static/* deploy/", |
Collaborator
Author
There was a problem hiding this comment.
TODO: we need to bundle and copy sass files to the deploy directory
Collaborator
Author
|
Since i have idea how coffeescript works i've been converting it back to JS with this haha |
danieldelcore
commented
Jun 23, 2020
| @@ -139,7 +139,7 @@ | |||
| </p> | |||
| <script src="//www.gstatic.com/firebasejs/3.1.0/firebase.js"></script> | |||
| <script src="/js/vendors.min.js"></script> | |||
Collaborator
Author
There was a problem hiding this comment.
@andrevenancio we can probably drop vendors and import directly from npm now :D
danieldelcore
commented
Jun 23, 2020
| constructor(private x: number = 0, private y: number = 0) {} | ||
|
|
||
| // TODO: Is this supposed to be used? | ||
| // private _add(v1, v2) { |
Collaborator
Author
There was a problem hiding this comment.
@andrevenancio i have no idea if this was being used here. Looks like no 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.