fix: contain long custom provider URLs - #11
andrebrait wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughProvider configuration layouts now wrap long names, URLs, descriptions, navigation labels, and actions within narrow panels. The changelog records these responsive layout fixes. ChangesProvider responsive layout
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Responsive provider layout changes are ready to merge; no material runtime or product risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified in the reviewed changes.
Pull request overview
Improves responsive custom-provider layouts so long names, URLs, and hostnames remain contained.
Changes:
- Adds wrapping and shrinking for provider identity content.
- Wraps provider actions on narrow screens.
- Documents the fix in
CHANGELOG.md.
File summaries
| File | Summary |
|---|---|
components/ModelsConfig.tsx |
Adds responsive wrapping and long-text containment. |
CHANGELOG.md |
Records the unreleased layout fix. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Follow-up c4f504b addresses the screenshot: the Custom Providers navigation label is no longer clipped, and Save stays inside the footer. Provider navigation now wraps, as do footer text/actions and the Add Provider header. Verified the complete real ModelsConfig panel in Chromium with fresh application CSS and application fonts: empty state at 320/360/402/768/1024/1440px; populated long-URL state at 320/402/768/1440px; long save error at 320px. Every panel button stays contained, both navigation groups show complete labels, and footer scrollWidth matches clientWidth. Save was exercised through keyboard interaction against an isolated fixture; no real provider configuration was changed. Typecheck and component ESLint passed. Temporary smoke files and server were removed. |
|
@coderabbitai review |
|
There was a problem hiding this comment.
🔵 Needs a closer look
The segmented control may still exceed its available width by 2px on narrow settings panels.
Review details
Suppressed comments (1)
app/globals.css:2342
max-width: 100%limits only the content box by default, while this control still adds a 1px border on both sides. When the segmented control reaches the available width on a narrow settings panel, its outer box can therefore be 2px wider and create horizontal overflow despite the containment fix. Set the control tobox-sizing: border-box(or subtract the border from the max width).
max-width: 100%;
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
Reviewed Copilot’s suppressed border-box concern on 26cf4b1. No change needed: app/globals.css imports Tailwind, whose preflight applies box-sizing: border-box globally to every element (node_modules/tailwindcss/preflight.css:7–15). The real-component Chromium check used the compiled application CSS: at a 320px viewport, the provider panel has 292px content width and each segmented control has 290px clientWidth plus its two 1px borders, totaling exactly 292px. Navigation scrollWidth equals clientWidth, labels remain visible, and the entire panel has no horizontal overflow. Adding a component-specific duplicate reset would not change behavior. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Verification
No provider data, validation, or API behavior changed. Temporary browser smoke scaffolding was removed. Unrelated local PWA work is excluded from this branch.
Summary by CodeRabbit