Repository navigation
fanctrlplus2: one value per column in the dashboard widget - #16
Conversation
The temperature cell packed the value and its source into fixed 30px and 55px grid tracks: "40 °C" ran into the source, and a long disk group name was cut mid-word and drawn over the RPM column on hover (#13). The widget now has one value per column, with units in the headers: Name, Temp (°C), Source, Speed (RPM), PWM (%), Status, Run. Cells clip with an ellipsis and never overflow, numbers are right-aligned, and names and sources carry their full text as a tooltip. On narrow screens the headers are abbreviated and each fan's source moves to a second line. The server sends the PWM percentage as a bare number, fan names are escaped, and the unused JSON field and mangled regexes are gone.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe fan dashboard now displays temperature, source, RPM, PWM, status, and run controls in separate labeled cells. The response fields and row updates use raw values and defined fallback values. ChangesFan dashboard
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The dashboard changes are mergeable after normal checks. A narrow tile in a wide viewport has not been shown to cause the reported display problem. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Renders of the widget: the real Before (
After, desktop: one value per column, with units in the headers. The long disk-group source ends in "…" and shows in full on hover.
After, narrow screen (360px tile): abbreviated headers, and each fan's source on a second line.
The images live on the review-only branch |
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
The dashboard widget's temperature cell packed the value and its source into fixed 30px and 55px grid tracks. "40 °C" ran into the source, and a long disk-group name was cut mid-word with no ellipsis, then drawn over the RPM column on hover by Unraid's
span.w18:hover { overflow: visible }(reported in #13).The widget now has one value per column, with units in the headers:
--for temperature (previously*), since the Source column says "Idle".Fanctrl2Dashboard.phpsends the PWM percentage as a bare number and drops the unusedtempfield; the widget is its only consumer.$begin:math:text$…in an earlier commit are gone.Verification: rendered the real page output with Unraid's
DashStats.css(10px root, 1.1rem uppercase headers) in headless Chromium at tile widths of 780, 520, 380 and 340px. Nothing overflows; only long names and the long disk-group source are ellipsized. Not yet checked on a real Unraid dashboard.bash tests/run-all.shpasses.Summary by CodeRabbit
--. Fan values reset to this placeholder if a refresh fails.%sign, or as-when unavailable.