ESM fix - #12
Open
tpluscode wants to merge 2 commits into
Open
Conversation
|
@andreasbm would appreciate this merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
In addition to
type: module, the modules must all be referenced with.jsextension. As a side note, I can highly recommend using eslint-plugin-require-extensions which ensures the extensions are usedThe second commit is a little unrelated but it's the minimum I had to do to have the compilation work. Since you do not lock on a specific version of dependencies, I got type errors from
@types/babel__traverse. Most likely caused by an old version of typescript, hence I added v5 to the dev dependencies. Let me know if you'd like this handled differently