Repository navigation
Add CVE aliases to advisory labels - #5
Merged
Merged
Conversation
- label format 1.0.1: an advisory label carries `aliases`, the CVE grype's `--by-cve` reports its match as, so it pairs that match too. The verdict stays on the advisory - the port takes it from the first CVE the advisory's DB record names (grype's own order) and writes 1.0.1 - `scripts/advisory_aliases.py` backfills committed advisory labels, which the port's reconcile leaves alone. It reads the CVE off a `--by-cve` scan of the image's SBOM where one is fetched, since grype reports a match it merged from two records (binary rpm found directly and via its source rpm) under the lowest CVE instead, and falls back to the DB's first Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
- 531 of 537 advisory labels get the CVE grype `--by-cve` reports them as (grype v0.120.1, DB built 2026-10-23): 381 read off a scan of the image's SBOM, 150 from the DB's first CVE where grype no longer reports the match - ALAS2-2021-1710 and two FEDORA advisories name no CVE, so their 6 labels stay without - lastUpdated is untouched: aliases say how grype reports the match, not what the call is Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
- `schema/matches/schema-1.0.1.json` adds `aliases` on advisory labels - P-11: an advisory label carries the CVE `--by-cve` reports it as, so it pairs that match too. It is still never moved to the CVEs the advisory names Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
marked this pull request as ready for review
October 27, 2026 03:20
wagoodman
marked this pull request as ready for review
October 27, 2026 03:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisory labels didn't pair under grype
--by-cvebecause the port from vulnerability-match-labels droppedeffective_cve. This carries it back asaliases(label format 1.0.1).aliaseson advisory labels going forwardscripts/advisory_aliases.pybackfills the existing ones. Where possible it uses the CVE grype actually reports for the match (a--by-cvescan of the image's SBOM), falling back to the advisory's first CVE in the DB. grype doesn't always report the first one: a match merged from the binary and source rpm reports the lowestschema-1.0.1.jsonand amends P-11aliasesbut doesn't act on them yet; that needs Pair advisory labels to the CVE grype reports them as yardstick#719 and another pin bump