Support mTLS in Impersonated Credentials #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally use mTLS endpoints in impersonated credentials if CLOUDSDK_CONTEXT_AWARE_USE_CLIENT_CERTIFICATE or GOOGLE_API_USE_CLIENT_CERTIFICATE is true. Updated `_mtls_helper.check_use_client_cert` to check for `CLOUDSDK_CONTEXT_AWARE_USE_CLIENT_CERTIFICATE`. Added mTLS endpoints to `google/auth/iam.py`. Modified `google/auth/impersonated_credentials.py` to use mTLS endpoints when appropriate.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Conditionally use mTLS endpoints in impersonated credentials if CLOUDSDK_CONTEXT_AWARE_USE_CLIENT_CERTIFICATE is true or google.auth.transport._mtls_helper.check_use_client_cert() is true. Added mTLS endpoints to `google/auth/iam.py`. Modified `google/auth/impersonated_credentials.py` to use mTLS endpoints when appropriate.
Conditionally use mTLS endpoints in impersonated credentials if google.auth.transport._mtls_helper.check_use_client_cert() is true. Added mTLS endpoints to `google/auth/iam.py`. Modified `google/auth/impersonated_credentials.py` to use mTLS endpoints when appropriate.
Conditionally use mTLS endpoints in impersonated credentials if google.auth.transport._mtls_helper.check_use_client_cert() is true. Added mTLS endpoints to `google/auth/iam.py`. Modified `google/auth/impersonated_credentials.py` to use mTLS endpoints when appropriate. Removed logic checking for `CLOUDSDK_CONTEXT_AWARE_USE_CLIENT_CERTIFICATE` environment variable as requested, relying solely on `check_use_client_cert()`.
Conditionally define IAM endpoints in `google/auth/iam.py` based on `google.auth.transport._mtls_helper.check_use_client_cert()`. If mTLS is enabled, the endpoints will point to `iamcredentials.mtls.googleapis.com`. This ensures impersonated credentials (and other users of `google.auth.iam`) use mTLS endpoints when appropriate. Reverted changes to `google/auth/impersonated_credentials.py` as they are now handled by `google/auth/iam.py`.
Conditionally define IAM endpoints in `google/auth/iam.py` based on `google.auth.transport._mtls_helper.check_use_client_cert()`. If mTLS is enabled, the endpoints will point to `iamcredentials.mtls.googleapis.com`. Added a safety check using `hasattr` to avoid `AttributeError` if `_mtls_helper` does not have `check_use_client_cert` (e.g. in some bundled environments). This ensures impersonated credentials (and other users of `google.auth.iam`) use mTLS endpoints when appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mTLS endpoints in impersonated credentials.
It updates
_mtls_helper.check_use_client_certto respectCLOUDSDK_CONTEXT_AWARE_USE_CLIENT_CERTIFICATE.It also conditionally switches the IAM endpoints in
impersonated_credentials.pybased on this check.Tests were updated to verify the new behavior of
check_use_client_cert.Note: Existing test
TestDecryptPrivateKey.test_successintests/transport/test__mtls_helper.pyis failing due toOpenSSL.crypto.signbeing removed in recent versions of dependencies, which is unrelated to these changes.PR created automatically by Jules for task 8690199261277670952 started by @amtk3