Repository navigation
Add Windows build to GitHub Actions - #22
Merged
Merged
Conversation
Add buildtools/win (gn windows-amd64) to DEPS, run all jobs under bash, set DEPOT_TOOLS_WIN_TOOLCHAIN=0, and handle the .exe suffix so windows-latest builds and runs hello/hello_unittest. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mini_chromium emits MSVC-style flags (/W4, /Zi, /std:c++23preview) on Windows, which the gcc_like (clang++) driver rejects. Pick msvc_toolchain_$current_cpu when current_os == "win", like crashpad. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pass mini_chromium_is_clang=false on Windows so the build uses the autodetected Visual Studio cl.exe and skips the clang-only flags, avoiding a large clang toolchain download. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Move checkout@v5, setup-python@v6, cache@v5 so the workflow no longer triggers the "Node.js 20 is deprecated" Actions warning. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
windows-latestto the CI matrix and make the Windows build actuallypass, rebased onto the latest
main(2026-06 DEPS update).Changes
buildtools/win(gnwindows-amd64CIPD,host_os == "win").ninja is already
${platform}-based, so it covers Windows automatically.msvc_toolchain_$current_cpuon Windows,
gcc_like_toolchainelsewhere (crashpad's pattern). The old codeforced
gcc_like_toolchaineverywhere, soclang++was handed MSVC-style flags(
/W4,/Zi,/std:c++23preview) and failed.windows-latest(fail-fast: falsekeeps mac/linux independent).shell: bash(Git Bash on Windows) — one set of steps.DEPOT_TOOLS_WIN_TOOLCHAIN=0+mini_chromium_is_clang=falseon Windows so thebuild uses the runner's Visual Studio
cl.exeand skips the large clang download..exesuffix when running the binaries.the "Node.js 20 is deprecated" warning.
Verification (GitHub Actions)
All three matrix jobs pass:
LINK hello.exe→Hello, world 1,[ PASSED ] 2 tests.No Node.js 20 deprecation warning.
🤖 Generated with Claude Code