Move quiescence out of the room: Exchanges owns the whole span - #44
Open
andreisavu wants to merge 1 commit into
Open
Move quiescence out of the room: Exchanges owns the whole span#44andreisavu wants to merge 1 commit into
andreisavu wants to merge 1 commit into
Conversation
The room held three pieces of lifecycle state of its own: whether a seat worked since the last settle, and the two waiter lists behind settled() and quiet(). Their transitions sat across eight methods, and the three-way branch in ended() was the widest context in the file. Exchanges now holds the open exchange, the stirred flag, and both promises. The room reads what is running off the seats and passes two booleans in at every transition. Every transition is synchronous and takes no model, so exchange.test.ts proves the lifecycle with no room: what opens one, what a settle closes and reports, when each promise resolves, and what the assistant's scheduler makes of a settle where a seat worked and one where none did. The room keeps one boolean, stopped. docs/exchange.md section 5 names the module and its transitions. Behaviour is unchanged; every existing test passes as it was. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BL6FaVKirZDMQmcL61mEUr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room held three pieces of lifecycle state of its own: whether a seat
worked since the last settle, and the two waiter lists behind settled()
and quiet(). Their transitions sat across eight methods, and the
three-way branch in ended() was the widest context in the file.
Exchanges now holds the open exchange, the stirred flag, and both
promises. The room reads what is running off the seats and passes two
booleans in at every transition. Every transition is synchronous and takes
no model, so exchange.test.ts proves the lifecycle with no room: what
opens one, what a settle closes and reports, when each promise resolves,
and what the assistant's scheduler makes of a settle where a seat worked
and one where none did.
The room keeps one boolean, stopped. docs/exchange.md section 5 names the
module and its transitions. Behaviour is unchanged; every existing test
passes as it was.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01BL6FaVKirZDMQmcL61mEUr