Feature: Add local make self-validate target (#372)

[jeremyeder]

Summary

• Implements make self-validate target for local Makefile quality validation
• Updates GitHub Actions workflow to use the new target
• Provides developers with same validation checks as CI before pushing

Changes

Makefile

• Added self-validate target that runs 8 comprehensive validation steps:
  1. Validate Makefile syntax
  2. Check shell scripts with shellcheck
  3. Verify required targets exist
  4. Validate .PHONY declarations
  5. Check for hardcoded values
  6. Test help target output
  7. Verify target documentation coverage
  8. Run comprehensive validation

GitHub Actions Workflow

• Replaced multiple inline validation steps with single make self-validate call
• Simplifies workflow maintenance
• Ensures local and CI validation logic stays in sync

Benefits

• Faster feedback: Developers can run make self-validate locally before pushing
• Single source of truth: Validation logic defined once in Makefile
• Easier maintenance: Changes to validation logic only need to be made in Makefile
• Consistency: Same checks run locally and in CI

Test Plan

• Run make self-validate locally - all checks pass
• Verify self-validate target is included in required targets list
• Verify .PHONY declaration includes self-validate
• Test that GHA workflow still runs correctly (will be tested in CI)

Testing

# Test locally
make self-validate

Expected output: All 8 validation steps pass with green checkmarks

Closes #372

🤖 Generated with Claude Code

[github-actions]

Claude Code Review

Summary

This PR successfully refactors the Makefile quality validation workflow by consolidating inline validation steps into a reusable make self-validate target. The implementation follows good software engineering principles (DRY, single source of truth) and provides developers with the same validation checks locally that run in CI.

Overall Assessment: Approve with Minor Recommendations

The code is well-structured, follows Make best practices, and significantly improves maintainability.

Issues by Severity

Blocker Issues

None - No issues that must be fixed before merge.

Critical Issues

None - No critical issues found.

Major Issues

1. Color Variables May Not Work in All CI Environments
While the fallback to printf escape codes is good, some CI environments may not interpret ANSI codes correctly. Consider adding CI_MODE check to disable colors in automated environments. Priority: Medium

2. Missing Error Handling for Help Target Failure
If make help fails, the validation continues anyway. Add explicit exit code checking. Priority: Medium

Minor Issues

1. Temporary File Not Cleaned Up on Error
If help validation check fails, /tmp/help-output.txt is left behind. Consider adding cleanup trap. Priority: Low

2. Documentation Comments Removed from Workflow
The workflow lost detailed agent instructions. Consider adding maintenance documentation to .claude/context/makefile-validation.md. Priority: Low

Positive Highlights

• Excellent DRY Refactoring - Single source of truth for validation logic
• Developer Experience - Local validation with clear, colored output
• Proper .PHONY Declaration
• Comprehensive Coverage - All 8 original validation steps preserved
• CI/CD Best Practice - Workflow simplified from 232 lines to 6 lines
• No Breaking Changes
• Self-Referential Validation - self-validate included in required targets

Final Verdict

APPROVED

High-quality refactoring that significantly improves developer experience and maintainability. Minor issues are non-blocking.

Merge Confidence: High

---

Review by: Claude Code Review Agent
Standards loaded: CLAUDE.md, backend-development.md, frontend-development.md, security-standards.md, k8s-client-usage.md, error-handling.md, react-query-usage.md
Review date: 2026-01-29

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.