Allow onboarding and clipboard-only dictation without Accessibility#629
Allow onboarding and clipboard-only dictation without Accessibility#629uzairansaruzi wants to merge 7 commits into
Conversation
MDM and privacy-conscious users were blocked finishing setup when Accessibility stayed Needed. Soft-gate that permission, fall back to clipboard output, and expose menu-bar Start/Stop so basic dictation still works. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
needs PR template
|
The PR Policy check is blocking this PR because required template information is missing. Please update the PR description with:
Visual files detected:
Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template. If this remains incomplete for 48 hours after opening, the PR may be closed. |
Greptile SummaryThis PR soft-gates the Accessibility permission requirement in onboarding, enabling users who cannot or choose not to grant it to still use dictation with clipboard output. It adds an explicit "Continue without Accessibility" skip action, auto-enables
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
removed
needs PR template
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a2efafce5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… guard. Keep clipboard-only delivery when Fluid is frontmost without Accessibility, replace stacked clipboard notifications with a stable ID, and disable menu Start/Stop during dictionary training. Co-authored-by: Cursor <cursoragent@cursor.com>
Show hotkey tryout whenever Accessibility is available, and surface the clipboard-only confirmation from TypingService's Accessibility fallback path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed remaining Greptile summary findings in the latest commit:
Earlier review threads (stable notification ID, Fluid-frontmost clipboard copy, dictionary-training menu guard) remain fixed in |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8398ce8c56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Route menu-bar stop through the same onboarding sandbox selection as hotkeys, and keep the Settings clipboard toggle synced when onboarding writes SettingsStore directly. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c33e6cf4fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t mid-stop. Avoid false "Copied to clipboard" banners when pasteboard write fails, and keep Start Dictation disabled while a menu-bar stop is still processing. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@greptileai please re-review — clipboard notification is now gated on copy success in 6f55cac |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f55cac2b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Track stop→transcribe depth on MenuBarManager from ContentView so hotkey and in-app stops keep Start Dictation disabled, not only menu-initiated stops. Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Description
Onboarding currently hard-requires Accessibility before Continue works, which blocks MDM-locked and privacy-conscious users who can still use mic-based dictation with clipboard output.
This PR soft-gates Accessibility with an explicit Continue without Accessibility action, auto-enables clipboard copy on skip, unblocks onboarding completion, adds clipboard-only runtime fallback (no silent drop), exposes menu-bar Start/Stop Dictation, and shows in-app Record/Stop in the playground when Accessibility is unavailable.
Type of Change
Related Issue or Discussion
Closes #627
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat Sourcesxcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO(passed; E2E whisper fixture skipped as in CI)Manual matrix:
copyTranscriptionToClipboardScreenshots / Video
Permissions soft-gate (mic required, Accessibility recommended, explicit skip):
Playground in-app Record when Accessibility is skipped:
Settings clipboard-only mode copy:
Notes
NotificationService(system notification), matching existing AI/audio fallback patterns.