Spdx tags: Use PSDX tags for this project by vinodkoul · Pull Request #7 · alsa-project/tinycompress

vinodkoul · 2020-09-09T07:26:19Z

Add SPDX tags and remove the license text, Also adds SPDX tags to files which have this missing

tinycompress project is licensed under LGPL 2.1 and BSD 3 Clause, so remove the license text and use SPDX tags Signed-off-by: Vinod Koul <vkoul@kernel.org>

Update to use SPDX tags in the C files. Ensure the Copyright and Author information is retained Signed-off-by: Vinod Koul <vkoul@kernel.org>

Update to use SPDX tags in the H files. Ensure the Copyright and Author information is retained Signed-off-by: Vinod Koul <vkoul@kernel.org>

The Makefile.am and Android.mk files do not contains any license information, add the SPDX tags in the files Signed-off-by: Vinod Koul <vkoul@kernel.org>

Since utils-lgpl in only licensed as LGPL-2.1, add the COPYING file mentioning this explicitly Signed-off-by: Vinod Koul <vkoul@kernel.org>

Use the /* ... */ style to add SDPX tags. Signed-off-by: Vinod Koul <vkoul@kernel.org>

The Makefile.am file do not contains any license information, add the SPDX tags in the files Signed-off-by: Vinod Koul <vkoul@kernel.org>

vinodkoul · 2020-09-09T07:27:55Z

@plbossart @charleskeepax Please do check the Copyright/Author info is not messed up -)

plbossart

see comments below

plbossart · 2020-09-09T12:43:30Z

COPYING

-
-tinycompress library for compress audio offload in alsa
-Copyright (c) 2011-2012, Intel Corporation
-All rights reserved.


@vinodkoul you cannot remove the Intel Copyright.
Copyright is a different concept to the license. It's fine to use SPDX for the license, the copyright needs to stay as is.

@plbossart If you look closely, the copyright is retained in src file where IMO it is apt. Here in COPYING file it feels a copy paste mistake, hence removal.

Some of these COPYING files only provide the license, others combine license and copyright. I don't know what the rule is and I am not a lawyer, so when in doubt I am asking you to please keep the copyright as is. It may be a mistake but that's not for me to approve.

plbossart · 2020-09-09T12:43:47Z

COPYING

-LGPL LICENSE
-
-tinycompress library for compress audio offload in alsa
-Copyright (c) 2011-2012, Intel Corporation.


same here, please keep the copyright for Intel.

plbossart · 2020-09-09T12:46:06Z

src/lib/compress.c

- */
+/* SPDX-License-Identifier: (LGPL-2.1-only OR BSD-3-Clause) */
+/* Copyright (c) 2011-2012, Intel Corporation */
+/* Author: Vinod Koul <vkoul@kernel.org> */


why not the kernel-style

// SPDX-License-Identifier: (LGPL-2.1-only OR BSD-3-Clause)
// Copyright (c) 2011-2012, Intel Corporation
// Vinod Koul <vkoul@kernel.org

-> I don't know what the official policy is but you did this work as an Intel employee. Your email no longer reflect that fact.

I felt that we can be simpler and use two styles, /* SPDX */ for code files.
and # SPDX for Makefiles.
Let me know if there is a strong reason to keep kernel style

The email refers to author of file and that persons updated email address, has nothing to do we who I was employed with (it was actually modified after I left Intel)

I don't care about style, but you created your own style here. why change?

plbossart · 2020-09-09T12:46:43Z

COPYING

-tinycompress is provided under a dual BSD/LGPLv2.1 license.  When using or
-  redistributing tinycompress, you may do so under either license.
+tinycompress is provided under:
+	SPDX-License-Identifier: LGPL-2.1-only OR BSD-3-Clause


why not use the same notation as in the rest of the files

SPDX-License-Identifier: (LGPL-2.1-only OR BSD-3-Clause)

this should, thanks for pointing

plbossart · 2020-09-09T12:47:23Z

src/utils/crecord.c

+/* Copyright (c) 2011-2012, Intel Corporation */
+/* Copyright (c) 2013-2014, Wolfson Microelectronic Ltd. */
+/* Author: Vinod Koul <vkoul@kernel.org> */
+/* Author: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> */


the C comments are really not very nice.

I would like simpler notation, so this feels better than using 3 styles

According to the kernel documentation (Documentation/process/license-rules.rst), the point of the different styles was to work round some tooling bugs regarding .lds files, which have since been fixed. So I don't think there is any issue with using a single style here, although I have no opinion on what style would be best.

plbossart · 2020-09-09T12:48:34Z

src/utils-lgpl/fcplay.c

+/* SPDX-License-Identifier: LGPL-2.1-only */

-//Copyright (c) 2011-2012, Intel Corporation
-//Copyright (c) 2018-2019, Linaro Ltd


why change this?

Code style change

plbossart · 2020-09-09T12:49:38Z

src/utils-lgpl/fcplay.c

-//SPDX-License-Identifier: LGPL-2.1-only
+/* SPDX-License-Identifier: LGPL-2.1-only */

-//Copyright (c) 2011-2012, Intel Corporation


I am not really confused as to whether this is indeed an Intel contribution. I don't think we added anything with LGPL-only, did we?

This was derived from cplay.c (lots of code copy) hence the original copyright was retained by me and new one added

I see. In that case, you should make it clearer. e.g.

Derived from cplay.c Copyright (c) 2011-2012, Intel Corporation

vinodkoul added 7 commits September 9, 2020 12:25

COPYING: Use SPDX tags

21afc62

tinycompress project is licensed under LGPL 2.1 and BSD 3 Clause, so remove the license text and use SPDX tags Signed-off-by: Vinod Koul <vkoul@kernel.org>

src: use SPDX tags in C files

2f3fcaf

Update to use SPDX tags in the C files. Ensure the Copyright and Author information is retained Signed-off-by: Vinod Koul <vkoul@kernel.org>

include: use SPDX tags in H files

e832243

Update to use SPDX tags in the H files. Ensure the Copyright and Author information is retained Signed-off-by: Vinod Koul <vkoul@kernel.org>

tinycompress: use SPDX tags in build files

4a0a95e

The Makefile.am and Android.mk files do not contains any license information, add the SPDX tags in the files Signed-off-by: Vinod Koul <vkoul@kernel.org>

utils-lgpl: Add COPYING file

b4a5d80

Since utils-lgpl in only licensed as LGPL-2.1, add the COPYING file mentioning this explicitly Signed-off-by: Vinod Koul <vkoul@kernel.org>

fcplay: update SDPX tag style

0250d25

Use the /* ... */ style to add SDPX tags. Signed-off-by: Vinod Koul <vkoul@kernel.org>

utils-lgpl: use SPDX tags in build files

3b6fdbf

The Makefile.am file do not contains any license information, add the SPDX tags in the files Signed-off-by: Vinod Koul <vkoul@kernel.org>

plbossart suggested changes Sep 9, 2020

View reviewed changes

Conversation

vinodkoul commented Sep 9, 2020

Uh oh!

vinodkoul commented Sep 9, 2020

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinodkoul Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vinodkoul Sep 10, 2020 •

edited

Loading