async: fix snd_async_del_handler for TIMER type - #525
Open
LilyKing2026 wants to merge 1 commit into
Open
LilyKing2026 wants to merge 1 commit into
LilyKing2026 wants to merge 1 commit into
Conversation
snd_async_del_handler() has two switch statements that handle PCM and CTL handler types, but not TIMER. When a TIMER type handler is deleted, both switches fall through to default and trigger assert(0), crashing any program that uses snd_async_add_timer_handler(). Add the missing SND_ASYNC_HANDLER_TIMER cases to both switches, and include timer_local.h to access struct _snd_timer. Signed-off-by: Jin Li <jinli@lanxincomputing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
snd_async_del_handler()has two switch statements that handlePCMandCTLhandler types, but notTIMER. When a TIMER type handler is deleted, both switches fall through todefaultand triggerassert(0), crashing any program that usessnd_async_add_timer_handler().Reproduction
On Ubuntu 26.04 (alsa-lib 1.2.15.3), running
selftests/alsa/utimer-test:global-timer: async.c:166: snd_async_del_handler: Assertion '0' failed.Aborted (core dumped)Fix
SND_ASYNC_HANDLER_TIMERcases to both switches insrc/async.ctimer/timer_local.hto access the members ofstruct _snd_timerTesting
After rebuilding and installing alsa-lib,
utimer-testchanges from FAIL to PASS:# PASSED: 2 / 2 tests passed.