Skip to content

[PP-7833] Disable GraphQL precedence tests#4117

Merged
yndajas merged 1 commit into
mainfrom
disable-precedence-tests
Jul 7, 2026
Merged

[PP-7833] Disable GraphQL precedence tests#4117
yndajas merged 1 commit into
mainfrom
disable-precedence-tests

Conversation

@yndajas

@yndajas yndajas commented Jul 7, 2026

Copy link
Copy Markdown
Member

Per the comments, we're disabling these for now given our GraphQL functionality is not in active development and they are therefore wasting CI resources. This adds a check against GraphQL and link expansion files to remind us to re-enable them if we work on code that these tests are likely to exercise. This change can be reverted when that is the case

@yndajas yndajas force-pushed the disable-precedence-tests branch 3 times, most recently from 852f684 to 3fe6995 Compare July 7, 2026 14:30
AgaDufrat
AgaDufrat previously approved these changes Jul 7, 2026

@AgaDufrat AgaDufrat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'd probably just remove them instead of leaving a long comment. We can always revert the commit and update the setup, if things change.

Per the comment, we're removing these from the CI workflow for now given
our GraphQL functionality is not in active development and they are
therefore wasting resources. This adds a check against GraphQL and link
expansion files to remind us to re-enable them if we work on code that
these tests are likely to exercise. This change can be reverted when
that is the case
@yndajas yndajas force-pushed the disable-precedence-tests branch from 31d7bc9 to 6090f1b Compare July 7, 2026 14:40
@yndajas

yndajas commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

LGTM. I'd probably just remove them instead of leaving a long comment. We can always revert the commit and update the setup, if things change.

Much cleaner!

@yndajas yndajas requested a review from AgaDufrat July 7, 2026 14:46
@yndajas yndajas merged commit b1e987a into main Jul 7, 2026
16 checks passed
@yndajas yndajas deleted the disable-precedence-tests branch July 7, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants