Update frontend apps to ensure the new functional colour custom prope…#5645
Draft
Conversation
luke-booker
force-pushed
the
update-frontend-apps-to-ensure-the-new-functional-colour-custom-properties-are-excluded-from-secondary-stylesheets
branch
from
4aeda37 to
0a4ee0d
Compare
…rties are excluded from secondary stylesheets
luke-booker
force-pushed
the
update-frontend-apps-to-ensure-the-new-functional-colour-custom-properties-are-excluded-from-secondary-stylesheets
branch
from
0a4ee0d to
3d8e269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In Design System v6, importing the core base styles automatically outputs a massive block of CSS custom properties such as colour variables.
Why
The primary stylesheet (application.scss) must output these variables so the application renders its colours correctly. However, if secondary or standalone stylesheets also import the base, they will include an identical and redundant copy of the same code.
Using the
$govuk-output-custom-properties: false;flag in secondary files tells the compiler to provide the layout tools required but don’t duplicate the variables we’ve already loaded. This will keep the compiled asset file sizes lean and free of duplicates.Jira card: NAV-18925
Visual changes