Standardize History pages#5632
Draft
KludgeKML wants to merge 13 commits into
Draft
Conversation
- This allows derived presenters to get a standard set of options they can expose as `breadcrumb_option`, overriding the breadcrumbs value if necessary (or if they just need home, they can delegate to the default method)
- Adding a standard content_presenter method (which will return the value of @content_presenter or a default content presenter) allows us to devolve certain view choices to a presenter but also override it easily for specific cases.
KludgeKML
force-pushed
the
history-deflexible
branch
from
6bea926 to
397c0f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces FlexiblePage version of History pages with standardized version (with its own controller, a presenter to contain presentational methods previously in the model, and its own view based on the header_sidebar_content layout).
Why
Jira card: https://gov-uk.atlassian.net/browse/[CARD-ID]
Visual changes