Support aggregate cookie#5591
Draft
MartinJJones wants to merge 5 commits into
Draft
Conversation
MartinJJones
force-pushed
the
support-aggregate-cookie
branch
from
1b2b2d0 to
302d0d9
Compare
- Update cookie settings page content - Add new aggregate usage cookie option - Update the page title to be the same as the h1
Normalize locales (remove whitespace, sort keys alphabetically for example)
Delete the unused locale translation keys listed below using the command `bundle exec i18n-tasks rm 'cookies.[key]'` - explanation_html - cookies.four_types - cookie_settings - google_info - how_you_got - pages_visited - clicks - lux_explain - lux_info - google_share
Add missing keys with placeholders
MartinJJones
force-pushed
the
support-aggregate-cookie
branch
from
302d0d9 to
e2d90e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support aggregate cookie:
LandingPageMapwhen aggregate is trueWhy
To support the new aggregate cookie
Jira cards:
https://gov-uk.atlassian.net/browse/NAV-18724
https://gov-uk.atlassian.net/browse/NAV-18754
Blocked by: alphagov/govuk_publishing_components#5389
Visual changes
Current cookie settings page: https://www.gov.uk/help/cookies
Update cookie settings page: https://govuk-frontend-app-pr-5591.herokuapp.com/help/cookies