[PNP-9933] Add govuk-browser-data standalone flexible page#5465
Draft
KludgeKML wants to merge 38 commits into
Draft
[PNP-9933] Add govuk-browser-data standalone flexible page#5465KludgeKML wants to merge 38 commits into
KludgeKML wants to merge 38 commits into
Conversation
- A wrapper around a Table component that takes data and optionally a caption.
- Derives from FlexiblePage, this is intended to be created directly by a specialist controller for the moment, but later it can be turned into a content item perhaps, and rendered normally by the flexible page controller.
- Takes GA4 export files (from the /ga4_exports directory, also added as an ignore), and processes them into suitable data files for /govuk-browser-data
- The current use of these sections is for massive tables, so move to wrapping with a div that will let the table show its own horizontal scroll bar if appropriate.
- run `bundle exec rake make_csvs`
KludgeKML
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Proof of concept of hosting govuk-browser-data on gov.uk itself, based on a flexible page with no content item (it'll need a minimal one for routing, but that can be a special route for now).
Why
Jira card: https://gov-uk.atlassian.net/browse/PNP-9933
Visual changes
https://govuk-frontend-app-pr-5465.herokuapp.com/govuk-browser-data