[DO NOT MERGE] Change the share method text from Twitter to X#5371
Draft
jon-kirwan wants to merge 4 commits into
Draft
[DO NOT MERGE] Change the share method text from Twitter to X#5371jon-kirwan wants to merge 4 commits into
jon-kirwan wants to merge 4 commits into
Conversation
jon-kirwan
force-pushed
the
change-the-share-method-text-from-twitter-to-x-
branch
from
895214e to
ffa8a3e
Compare
jon-kirwan
force-pushed
the
change-the-share-method-text-from-twitter-to-x-
branch
from
5f9f420 to
a6eb63f
Compare
jon-kirwan
force-pushed
the
change-the-share-method-text-from-twitter-to-x-
branch
from
a6eb63f to
87c9a87
Compare
jon-kirwan
changed the title
jon-kirwan
force-pushed
the
change-the-share-method-text-from-twitter-to-x-
branch
2 times, most recently
from
543a2ad to
0badce6
Compare
Update share text to include a 'Share on' prefix and replace 'Twitter' with 'X'.
Not needed. The hidden text defaults to "Share on", and since the visible text already reads "Share on…", the hidden text would just repeat it, so it isn’t required
jon-kirwan
force-pushed
the
change-the-share-method-text-from-twitter-to-x-
branch
from
0badce6 to
8ec765b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change the share method text to:
Review URLs:
press_release)open_call_for_evidence)Why
Visual changes
Before
After
Anything else
Note that this change only updates the link text for a few document types in Frontend that set the share text within the application (call for evidence, consultation, and news stories).
I’ve also updated the share URL from
https://twitter.com/share?url=#{share_url(base_path)}&text=#{ERB::Util.url_encode(title)}tohttps://x.com/share?url=#{share_url(base_path)}&text=#{ERB::Util.url_encode(title)}. I couldn’t find this documented anywhere, but it appears to work correctly and redirects to x.