Repository navigation
Fix manually triggerable events bug - #106
Merged
Merged
Conversation
Condition reset and suspend log messages are now all at info or warn level
Add a possible last resort error conversion function, that converts from pointers (`Box<Error>`) to whenever specific errors: it should actually almost never be used
Refactor DBus checks for contained string-likes in arrays and dictionaries: in the latter case only the keys are checked, and the contents are not inspected, this should spare some memory and CPU cycles
Stop converting DBus arrays to test whether an integer is contained, and just check for inclusion as a value: zvariant comparison operators just take care of discarding invalid comparisons; even though this may lead to tests for non integer arrays (which will fail anyway), avoiding building new arrays will save allocations and CPU cycles in general
This fixes #104 by splitting the list of events in two separate lists, one for external ones, and another for manually triggerable ones: both are rw-locked instead of just locked, so that multiple reads can occur at the same time, and are independent so that triggerable events do not have to wait for the listener to release the event list; also, #105 is fixed by simplifying the registry methods, although more can be done for simplification in other places
almostearthling
marked this pull request as draft
June 24, 2026 14:15
almostearthling
added
bug
almostearthling
marked this pull request as ready for review
June 24, 2026 14:17
almostearthling
commented
Jun 24, 2026
More simplifications and cuts in the interface of items, as well as registries: many checks that were actually ignored, or performed on always-succeeding code, have been ditched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging this branch would:
Resultenums in registries #105and due to the substantial changes and reintroduciton of manually triggerable events the version is bumped to 1.3.0.