Fix build error count to report actual number of errors#363
Draft
Fix build error count to report actual number of errors#363
Conversation
…esult.diagnostics.length Co-authored-by: bterlson <11236+bterlson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build tool to accurately count compilation errors
Fix build error count to report actual number of errors
Feb 13, 2026
Co-authored-by: bterlson <11236+bterlson@users.noreply.github.com>
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
bterlson
had a problem deploying
to
github-pages
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build output reported "completed with 0 errors" even when errors existed because the error count used
emitResult.diagnostics.length(emit-phase only) instead ofallDiagnostics.length(pre-emit + emit).allDiagnostics.lengthfor the error message, which already aggregates both diagnostic sourcesreportDiagnostics(emitResult.diagnostics)call —reportDiagnostics(allDiagnostics)already runs unconditionally above💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.