Keep vtable hooks installed until extension unload#2513
Open
Mikusch wants to merge 2 commits into
Open
Conversation
Member
|
I'm almost okay to take this as-is, nice refactoring btw. But I will make a commit of my own on the PR to keep the unhook behaviour as it currently is, no specific reasons other than I don't want to diverge too much from SH baseline until the other PR lands. We can always revisit the unhooking process then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the last callback of a vtable hook deleted the
CVTableHookDetailsthe next frame, butKHook::RemoveHook(id, true)only queues the actual unlink on a worker thread. Until that ran, the hook kept dispatching through freed memory. Instead of tearing hooks down at runtime, they now stay installed until the extension unloads, and dispatch just bails out early when nothing is hooked anymore. While in there, I also refactored the copy-pasted dispatch code in sdkhooks.