Allow end user to define a label for the empty option in a select - #802
Open
anubisthejackle wants to merge 3 commits into
Open
Allow end user to define a label for the empty option in a select#802anubisthejackle wants to merge 3 commits into
anubisthejackle wants to merge 3 commits into
Conversation
Member
|
This seems useful to me. A unit test for this behavior would be helpful alongside the other |
Contributor
Author
|
@dlh01 You're right. I've updated the label name and added a test for this. |
mboynes
reviewed
Mar 22, 2021
Co-authored-by: Matthew Boynes <mboynes+git@alley.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exactly as it says. This PR adds a parameter "first_empty_label" that allows changing of the displayed name for empty options. The value of this option remains empty.