Allow consistent filtering of datasource items - #696
Open
ethitter wants to merge 3 commits into
Open
Conversation
ethitter
added a commit
to alleyinteractive/fm-zones
that referenced
this pull request
Feb 16, 2018
Until alleyinteractive/wordpress-fieldmanager#696 or something like it is available, we need a custom datasource to manipulate its output.
kjbenk
approved these changes
Feb 16, 2018
kjbenk
left a comment
kjbenk
left a comment
Contributor
There was a problem hiding this comment.
This looks good, but it would be nice to have proper filter docblocks for each of the new filters :)
This was referenced Oct 23, 2018
astratagem
pushed a commit
to spiritedmedia/wordpress-fieldmanager
that referenced
this pull request
Oct 23, 2018
Integrate upstream PR alleyinteractive#696 "Allow consistent filtering of datasource items"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term datasource already includes a filter on its
get_items()return value; this carries that to the remaining datasources. Additionally, I've introduced a filter onget_items_for_ajax()in case that output needs to be modified in response to changes made via theget_items()filters.#575 is related, but more-narrowly focused. If this PR is accepted, #575 can likely be closed.