Skip to content

Fix pipeline tool result rendering#157

Merged
guima-why merged 4 commits into
mainfrom
codex/fix-pipeline-repl
Jul 9, 2026
Merged

Fix pipeline tool result rendering#157
guima-why merged 4 commits into
mainfrom
codex/fix-pipeline-repl

Conversation

@guima-why

Copy link
Copy Markdown
Collaborator

Summary

  • trust transcript-local tool result and image cache artifact directories so follow-up shell reads do not require extra approval
  • compact noisy pipeline validation errors for complete_step and ask_user_question in live rendering and legacy replay
  • harden tool render metadata persistence to JSON-safe known keys and render cloud API summaries from the current output payload

Root Cause

  • Transcript artifact directories were not treated as trusted task-local paths.
  • Pipeline schema validation errors were stored/rendered as raw provider-facing validation text, which made the UI dump large error messages.
  • Cloud API compact rendering could use cached _last_result data instead of the current tool output, causing repeated-looking RequestId rows in compact UI.

Validation

  • uv run pytest tests/pipeline/engine/test_ask_user_question_tool.py tests/agent/test_agent_loop_new.py tests/ui/test_renderer_helpers.py tests/test_i18n.py tests/tools/cloud/test_base_api.py -q -> 168 passed
  • make lint -> ruff and ty passed
  • Earlier full suite on this branch: make test -> 8554 passed, 1 skipped

@guima-why guima-why marked this pull request as ready for review July 9, 2026 13:36
@guima-why guima-why merged commit abbb8da into main Jul 9, 2026
12 checks passed
@guima-why guima-why deleted the codex/fix-pipeline-repl branch July 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant