Harden A2A safe mode and selling tools#154
Merged
Merged
Conversation
f383ffd to
2e1f96d
Compare
2e1f96d to
b00e88c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ros_stack_instancesand update user-facing safe-mode messages with translations.Impact
This keeps
auto_approve_permissions=Trueusable for A2A deployments while preventing deployed normal-chat sessions from freely invoking shell, file-write/edit, or MCP-style tools. Existing local behavior remains unchanged unlessIAC_CODE_A2A_SAFE_MODEis enabled.Validation
make translateuv run pytest tests/tools/test_path_safety.py tests/services/permissions/test_pipeline.py tests/services/test_agent_factory.py tests/a2a/test_executor.py::test_executor_refreshes_cloud_tools_with_aliyun_metadata_for_reused_context tests/mcp/test_runtime_integration.py -quv run pytest tests/tools/test_path_safety.py tests/services/permissions/test_pipeline.py tests/services/test_agent_factory.py tests/a2a/test_executor.py::test_executor_refreshes_cloud_tools_with_aliyun_metadata_for_reused_context tests/mcp/test_runtime_integration.py tests/pipeline/engine/test_loader.py tests/pipeline/selling/test_pipeline_reviewing.py tests/pipeline/selling/test_ros_template_tool_scope.py tests/pipeline/selling/test_memory_policy.py tests/pipeline/selling/test_deploying_prompt.py -quv run ruff check src/iac_code/services/agent_factory.py src/iac_code/tools/path_safety.py tests/services/test_agent_factory.py tests/tools/test_path_safety.py