Add InfraGuard review pipeline#148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infraguardCLI so review can be enabled only when the required tool is available.infraguard policy update.infraguard_scanpipeline tool with structured scan output, concise and expanded rendering, result redaction, policy/aspect expansion, and deterministic handling of CLI errors.evals.jsonfor the review skill.Motivation
The selling pipeline previously had a placeholder review skill. The new workflow makes the review step actionable by using InfraGuard as the source of policy findings, allowing the agent to repair generated ROS templates and validate them before continuing. The prerequisite flow also prevents non-interactive runs from hanging or failing unpredictably when InfraGuard is not installed, while still giving REPL users a guided installation path.
User Impact
Implementation Notes
pipeline.yamldefines the InfraGuard prerequisite, direct binary assets for macOS/Linux/Windows, version constraints, post-install policy update, review aspects, and blocking severities.Validation
make test8228 passed, 1 skipped, 271 warningsmake lintruff check src/ tests/: all checks passedty check src/: all checks passedlint: passedformat: passedNotes