Remove setup/install/test boilerplate - #53
Open
jamezpolley wants to merge 3 commits into
Open
Conversation
I'm not sure if the Requirements section of the docs is really required; but assuming that it is, I've added a couple of words to make it clear that the mentioned dependencies are only installed if required.
Begins removes lots of argparse boilerplate; pbr removes lots of setup.py boilerplate.
This enables easier testing across multiple versions of python. Using this, I've been able to confirm that 117 tests pass on py26 and py27, with 122 passing on py3.3 and py3.4 (I don't have py3.3 available) Travis config is now done mostly automatically via tox-travis
Author
|
This is quite a substantial change - and pbr and tox aren't exactly easy to wrap one's head around. My apologies for the braindump! |
Author
|
This removes the coverage testing, which is presumably not what we want to do. http://lists.idyll.org/pipermail/testing-in-python/2014-November/006224.html suggests a way to restore the coverage testing - and still get the benefits of tox (eg, easily testing on multiple versions of python) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result, a developer can now simply run "tox" on the local machine and test in as many python versions as they have available - and Travis will run the same tests.
pbr reads install_requires from requirements.txt, so we can add argparse and funcsigs there (protected by environment markers so that they're only installed if required)
When pbr runs it will, by default, try to autogenerate an AUTHORS file and a CHANGELOG from the git logs. This can be disabled by exporting SKIP_GENERATE_AUTHORS=1 and SKIP_WRITE_GIT_CHANGELOG=1 before running setup.py